Repository navigation
fix(e2e): install pinned protoc for standard targets - #14751
prekshivyas wants to merge 1 commit into
Conversation
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Authoring session — opening
|
Code coverage overviewLanguages: TypeScript TypeScript / code-coverage/plugin
View coverage of the 10 most impacted files.
TypeScript / code-coverage/cli
View coverage of the 10 most impacted files.
ℹ️ Calculations represent line coverage. Results may change as calculations are updated. Updated |
|
@coderabbitai review |
Action performed
|
|
PR Review Advisor finished for commit Request review only when Require no Advisor blockers is green. |
Outcome
Standard E2E targets install the pinned v1
protocbefore preparing the workspace. Their config-export checks can build the Rust parser instead of failing because the compiler is absent.Reason
Hermes security job 136822303481 exported both CLI aliases successfully, then failed the pinned parser build with
Could not find protoc. The shared standard profile omitted the prerequisite already installed by dedicated E2E jobs. This workflow omission also exists on the recorded main commit.Related issues
Refs #12603.
Changes
setup-v1-protocaction from accepted main commitc474038df67fcb22182298ac9a696c81e63f0ee2. Its four Linux/macOS archive hashes match the pinned parser manifest.Verification
vitest run --project e2e-support test/e2e/support/standard-profile-workflow-boundary.test.ts test/e2e/support/v1-parse-consumer.test.ts --maxWorkers=1— 36 passed in credential-free, network-denied native isolation.Review notes
Sensitive paths:
.github/workflows/e2e-standard-profile.yamland the validators undertools/e2e/. Pre-publication review consists of the authoring agent's four-file self-review and focused validation against mainc474038df67fcb22182298ac9a696c81e63f0ee2; independent review is pending. The PR remains draft during CI and automated review. Full E2E qualification remains pending; this prerequisite does not resolve the other failures in #12603.Signed-off-by: Prekshi Vyas prekshiv@nvidia.com
Summary by CodeRabbit